Make disbanding a firm a confirmable action like transfer proprietorship, making it clear that firm funds are given to the proprietor.
Activity
Ttesks created the issue
Pparadaux set priority to High
T
tesks
Shipped on develop (commit 871a127), together with PAR-86.
/firm disband <firm> is now a two-step confirmable action (in the spirit of the proprietorship-transfer flow, but lighter — no DB-backed request):
Warn — validates firm/proprietorship, then shows: the firm's balance returns to your personal account and the name cannot be reused, with a clickable /firm disband <firm> confirm to run within 60s.
Confirm — re-validates firm existence, archived state, and proprietorship, consumes the pending confirmation, then disbands.
Backed by FirmDisbandConfirmationService (in-memory, clock-injectable): one pending confirmation per player, single-use, matched to the exact firm so you can't warn on one firm and confirm-disband another, 60s TTL. Tested (within-TTL, no-request, wrong-firm, expiry, single-use); coverage gate green.
PParadauxIO linked a pull request: PR #6 open — Release: develop → main
PParadauxIO linked a pull request: PR #6 open — Release: develop → main
Sign in to comment
Join the conversation, react to comments and vote on this issue.
Shipped on
develop(commit871a127), together with PAR-86./firm disband <firm>is now a two-step confirmable action (in the spirit of the proprietorship-transfer flow, but lighter — no DB-backed request):/firm disband <firm> confirmto run within 60s.Backed by
FirmDisbandConfirmationService(in-memory, clock-injectable): one pending confirmation per player, single-use, matched to the exact firm so you can't warn on one firm and confirm-disband another, 60s TTL. Tested (within-TTL, no-request, wrong-firm, expiry, single-use); coverage gate green.