Paradaux
Issues

PAR-317

0

Address code-review findings: split TransactionService, dead deps, deprecated APIs, exception hygiene

In ProgressHighUnassignedChestShopImprovement

Fix the non-test findings from the quality review:

  • Q-001: split TransactionServiceImpl (1051 LOC) into sensible collaborators (partial-fill math, goods transfer, post-trade reactions); trim noisy comments.
  • Q-004: remove dead compileOnly deps (ItemBridge, log4j-core, RedProtect) + orphaned repos.
  • Q-005: migrate deprecated Bukkit text/item APIs (ChatColor, Sign getLine/setLine, ItemMeta getDisplayName/hasDisplayName, ItemStack getDurability) to Adventure/modern equivalents.
  • Q-006: log the swallowed Throwables in MarketListener best-effort hooks.
  • Q-007: make the AccountServiceImpl empty ExecutionException catch explicit.
  • Q-008: replace settle(..., boolean buy, ...) flag with a Direction enum.
  • Q-009: reduce services/impl static reach-back into ChestShop (inject data-folder/paths).
  • Q-010: replace vendored Base64 with JDK java.util.Base64 if the custom object-serialization features are dead. Skipped per direction: Q-002 (coverage — intentionally low until rearchitecture done) and the coverage-gate half of Q-003.

Resources

Comments

No comments yet.

Activity

  • ParadauxIO linked a pull request — PR #2 open — Last major release
  • ParadauxIO linked a pull request — PR #2 open — Last major release
  • ParadauxIO linked a pull request — PR #2 open — Last major release
  • ParadauxIO linked a pull request — PR #2 open — Last major release
  • ParadauxIO linked a pull request — PR #2 open — Last major release
  • ParadauxIO linked a pull request — PR #2 open — Last major release
  • ParadauxIO linked a pull request — PR #2 open — Last major release
  • ParadauxIO linked a commit — Commit 4c583b2 — Wire the coverage gate into check: 0.99 line + 0.99 branch on the in-scope set (PAR-317)
  • ParadauxIO linked a commit — Commit 50a36ea — Coverage: close shop/item service branch residuals (PAR-317)
  • ParadauxIO linked a commit — Commit a4ddb7b — Coverage: TransactionServiceImpl deleteEmptyShop keep-chest branch to 100% (PAR-317)
  • ParadauxIO linked a commit — Commit 1a498f0 — Coverage: EconomyServiceImpl to 100% (PAR-317)
  • ParadauxIO linked a commit — Commit 9c3c7b5 — Coverage: MaterialServiceImpl meta-class/null-meta/YAML-normalisation branches (PAR-317)
  • ParadauxIO linked a commit — Commit 9987aa5 — Coverage: GoodsTransfer to 100% line+branch (stackTo64 + update holders + reverse paths) (PAR-317)
  • ParadauxIO linked a commit — Commit 12261cd — Merge trade+economy + shop+item coverage; drop stub API interfaces (PAR-317)
  • ParadauxIO linked a commit — Commit ca25ae1 — Add unit tests for the trade + economy services (PAR-317)
  • ParadauxIO linked a commit — Commit e22ee7e — Coverage: shop+item services to 100% (PAR-317)
  • ParadauxIO linked a commit — Commit 2098f82 — Coverage: market+misc services to 100% (PAR-317)
  • ParadauxIO linked a commit — Commit 3c285f6 — Coverage: Base62 error paths + constructor to 100% (PAR-317)
  • ParadauxIO linked a commit — Commit 52b8f34 — Coverage: model package to 100% line+branch (PAR-317)
  • ParadauxIO linked a commit — Commit 0730b33 — Coverage: utils package to 100% line+branch (PAR-317)
  • ParadauxIO linked a commit — Commit 175530f — Coverage: model package to 100% (PAR-317)
  • ParadauxIO linked a commit — Commit 4399bb3 — test infra: MockBukkit + real-config test support for the coverage push (PAR-317)
  • ParadauxIO linked a commit — Commit e008989 — Q-010: close the legacy item-blob native-deserialization RCE sink (PAR-317)
  • ParadauxIO linked a commit — Commit bf59512 — Q-001: split TransactionServiceImpl into PartialFillCalculator + GoodsTransfer (PAR-317)
  • ParadauxIO linked a commit — Commit af9cc79 — Q-005: migrate deprecated Bukkit text/item APIs (PAR-317)
  • ParadauxIO linked a commit — Commit eb58f41 — Q-009: inject the data folder instead of reaching into ChestShop statics (PAR-317)
  • ParadauxIO linked a commit — Commit f0c2d79 — Review fixes: dead deps, exception hygiene, settle flag (PAR-317)
  • tesks created the issue