You’re viewing Paradaux’s public workspaceSign in to vote and comment Get taskl.ie for your team

Paradaux
Issues
PAR-310

PAR-310

Search in paradaux, or jump to…

Actions

Change themeDark, light or system↵

Copy current URL

Navigation

Issues

Board

Projects

Deployments

Teams

↑ ↓ navigate↵ openEsc close

Loading issues

Built with taskl.ie

Issues Projects Search

Loading issue

PAR-310 · Remove the AdminInventory fake-Inventory; model unlimited… · Paradaux · taskl.ie

Workspace

Projects Deployments

Teams

PParadauxSign in

PAR-310

Remove the AdminInventory fake-Inventory; model unlimited admin shops explicitly

AdminInventory was a 38-method Inventory implementation faking an infinite container so the real-shop trade code could be reused for unlimited admin shops — a naive shoehorn. Removed it and modelled the special case honestly: a unlimitedOwner flag (= admin shop && (no chest || FORCE_UNLIMITED_ADMIN_SHOP)) on the PendingTransaction/Transaction context. The owner side of stock/space validation is skipped when unlimited, and the goods move client-side only (buy spawns the stock into the client, sell vanishes it) via a new moveUnlimited() with the same snapshot/restore atomicity as transferItems. Deleted ChestShopSign.isAdminShop(Inventory) (the instanceof) — its two callers mapped exactly to unlimitedOwner (one was a redundant check in deleteEmptyShop, which already returns early for admin shops). isOwnerEconomicallyActive now takes the boolean. Verified: AdminShopTest (buy/sell) + ForceUnlimitedAdminShopTest all green.

Properties

Status: Pending release
Priority: Normal
Assignee: Unassigned
Labels: Improvement
Project: ChestShop
Milestone: No milestone

Details

Votes: 0 votes
Created: Jul 3

Sign in

Sign in to edit this issue, vote and comment.

Activity

tesks created the issue Jul 3
ParadauxIO linked a commit: Commit d9931e3 — Remove the AdminInventory fake-Inventory; model unlimited admin shops explicitly (PAR-310) Jul 3
tesks set status to Pending Release Jul 3

Sign in to comment

Join the conversation, react to comments and vote on this issue.