You’re viewing Paradaux’s public workspaceSign in to vote and comment Get taskl.ie for your team

Paradaux
Issues
PAR-297

PAR-297

Search in paradaux, or jump to…

Actions

Change themeDark, light or system↵

Copy current URL

Navigation

Issues

Board

Projects

Deployments

Teams

↑ ↓ navigate↵ openEsc close

Loading issues

Built with taskl.ie

Issues Projects Search

Loading issue

Workspace

Projects Deployments

Teams

PParadauxSign in

PAR-297 · Deep-dive cleanup: remove dead @Deprecated members + the… · Paradaux · taskl.ie

PAR-297

Deep-dive cleanup: remove dead @Deprecated members + the legacy multi-version ImplementationAdapter reflection

Follow-up deep dive after the util/service split (PAR-282).

Dead @Deprecated code (0 callers):

MaterialUtil.LONG_NAME, SHORT_NAME, MAXIMUM_SIGN_LETTERS
ShopBlockService.isShopChest(Block) + isShopChest(InventoryHolder)
PlayerInteract.canOpenOtherShops(Player)
ChestShopSign.isValidPreparedSign(String[])

Legacy multi-version cruft: ImplementationAdapter reflectively probes for Inventory.getHolder(boolean) / Block.getState(boolean) and falls back to the snapshot API if absent — but ChestShop compiles against Paper 1.21.11 where those overloads always exist (the upstream multi-version matrix was folded away). The reflection static-init, the dead fallback, and the utils/compat/ indirection (NonSnapshotInventoryHolder, NonSnapshotState) are all dead. Simplify ImplementationAdapter to direct getHolder(useSnapshot) / getLeftSide/getRightSide/getState(useSnapshot) calls; delete utils/compat/. Keep the 4 public methods (14 consumers unchanged).

Properties

Status: Pending release
Priority: Low
Assignee: Unassigned
Labels: Improvement
Project: ChestShop
Milestone: No milestone

Details

Votes: 0 votes
Created: Jul 2

Sign in

Sign in to edit this issue, vote and comment.

Activity

tesks created the issue Jul 2
ParadauxIO linked a commit: Commit b524a1b — Remove dead @Deprecated members + the legacy multi-version ImplementationAdapter reflection (PAR-297) Jul 2
tesks set status to Pending Release Jul 2
ParadauxIO linked a commit: Commit 24af419 — utils/ consistency pass: naming, private ctors, consolidation (PAR-308) Jul 3

Sign in to comment

Join the conversation, react to comments and vote on this issue.