PAR-296
0
Extract the pure prefix-matcher off @Singleton FirmSuggestionCache into utils/Suggestions
Pending ReleaseLowUnassignedBusinessImprovement
FirmSuggestionCache (a @Singleton stateful cache) carried a pure static match(pool, prefix, limit) prefix-filter used by 3 command-parameter resolvers — a generic mechanism living as a static on a stateful service (the same "static-on-a-service" smell cleaned in ChestShop).
Fix: move match to a pure utils/Suggestions; the 3 resolvers call Suggestions.match; the cache keeps only its instance cache methods. The 4 match unit tests move to SuggestionsTest. Coverage-neutral.
Resources
- commitf8aef42 Extract FirmSuggestionCache.match to pure utils/Suggestions (PAR-296)ParadauxIO/hibernia-economy
Comments
No comments yet.
Activity
- tesks changed status to Status → Pending Release
- ParadauxIO linked a commit — Commit f8aef42 — Extract FirmSuggestionCache.match to pure utils/Suggestions (PAR-296)
- tesks created the issue