PAR-105
0
Integration tests: fix false-green security test + flake + weak assertion
DoneNormalUnassignedTreasuryBug
Found auditing the economy-system-integration-tests release PR.
Fixed:
- False-green on a negative security test (high).
GovPlayerAccessTest.nonMemberNonOpPlayerCannotPayouthad its "non-member must not move gov funds" assertion inside atrywhosecatch (InterruptedException)swallowed the exception — an interrupt before the assert would pass the test having verified nothing. Removed the swallow; the method nowthrows InterruptedExceptionand cleanup stays infinally. Same shape fixed inmemberPlayerCanPayout. - Flake: two async commands back-to-back (med).
PayAccountTest.disambiguatesPlayerVsBusinessSameNamefired/pay-account player …then/pay-account business …with no settle; Treasury's single-worker async command handler can drop the second's response window. AddedLedger.asyncSettle()between them. - Weak assertion (med).
AdminInspectTest.balanceResolvesPlayerByNameasserted onlycontains("player " + name)— the literal input tokens, which an error reply would also contain. Now also asserts a rendered money figure (\d+\.\d{2}).
Residual (test hygiene, follow-up): several gov-command tests government account create accounts that are never archived/deleted, so each suite run permanently adds GOVERNMENT rows to the shared economy DB. Uniquely named so no re-run breakage, but unbounded growth — worth a teardown pass. The PR's "no account-creation side effects" claim is inaccurate on this point.
Comments
No comments yet.
Activity
- paradaux description: Description updated
- paradaux changed status to Status → Done
- tesks changed status to Status → Pending Release
- tesks created the issue