Paradaux
IssuesPAR-105Done
0

Integration tests: fix false-green security test + flake + weak assertion

Found auditing the economy-system-integration-tests release PR.

Fixed:

  1. False-green on a negative security test (high). GovPlayerAccessTest.nonMemberNonOpPlayerCannotPayout had its "non-member must not move gov funds" assertion inside a try whose catch (InterruptedException) swallowed the exception — an interrupt before the assert would pass the test having verified nothing. Removed the swallow; the method now throws InterruptedException and cleanup stays in finally. Same shape fixed in memberPlayerCanPayout.
  2. Flake: two async commands back-to-back (med). PayAccountTest.disambiguatesPlayerVsBusinessSameName fired /pay-account player … then /pay-account business … with no settle; Treasury's single-worker async command handler can drop the second's response window. Added Ledger.asyncSettle() between them.
  3. Weak assertion (med). AdminInspectTest.balanceResolvesPlayerByName asserted only contains("player " + name) — the literal input tokens, which an error reply would also contain. Now also asserts a rendered money figure (\d+\.\d{2}).

Residual (test hygiene, follow-up): several gov-command tests government account create accounts that are never archived/deleted, so each suite run permanently adds GOVERNMENT rows to the shared economy DB. Uniquely named so no re-run breakage, but unbounded growth — worth a teardown pass. The PR's "no account-creation side effects" claim is inaccurate on this point.

Comments

No comments yet.

Activity

  • paradaux description: Description updatedJun 7, 2026, 5:18 PM
  • paradaux changed status to Status → DoneJun 7, 2026, 5:18 PM
  • tesks changed status to Status → Pending ReleaseJun 6, 2026, 11:33 AM
  • tesks created the issueJun 6, 2026, 11:33 AM