Paradaux
Issues
Open ↗

PAR-53

0

Prevent '&' from being in firm names in the business project

DoneHighrianBusinessImprovement

Prevent the & character in firm names to avoid formatting/parsing issues.

Technical notes — business-rian/…/utils/NameValidator.FIRM_NAME = [A-Za-z0-9 _.\-&]{2,32} explicitly whitelists & (also ACCOUNT_NAME); FirmServiceImpl.createFirm is the reject point. In practice Hibernia's StringUtils.sanitize already strips & from @Arg strings, so it's mostly filtered before then — but the validator still permits it. Drop & from both regexes (+ update NameValidatorTest). Shares the chokepoint with PAR-19 (and any future renameFirm, PAR-11).

Resources

Comments

tesks · Jun 4, 2026, 9:56 AM

Code context — business-rian/…/utils/NameValidator.FIRM_NAME = [A-Za-z0-9 _.\-&]{2,32} explicitly whitelists & (and ACCOUNT_NAME too); FirmServiceImpl.createFirm is the reject point. In practice Hibernia's StringUtils.sanitize already strips & from @Arg strings, so it's mostly filtered before it gets there — but the validator still permits it.

Fix: drop & from the FIRM_NAME/ACCOUNT_NAME regexes (+ update NameValidatorTest). Shares the single validation chokepoint with PAR-19, and any future renameFirm (PAR-11) must route through it too.

Activity

  • ParadauxIO linked a commit — Commit 7d7f8ed — Add staff/DOC firm administration commands (PAR-11)
  • ParadauxIO linked a commit — Commit 9538158 — Reject '&' in firm + account names (PAR-53)
  • ParadauxIO changed status to Status → Done
  • ParadauxIO linked a pull request — PR #6 merged — Release: develop → main
  • ParadauxIO linked a pull request — PR #6 open — Release: develop → main
  • ParadauxIO linked a pull request — PR #6 open — Release: develop → main
  • ParadauxIO linked a pull request — PR #6 open — Release: develop → main
  • ParadauxIO linked a pull request — PR #6 open — Release: develop → main
  • ParadauxIO linked a pull request — PR #6 open — Release: develop → main
  • ParadauxIO linked a pull request — PR #6 open — Release: develop → main
  • ParadauxIO linked a commit — Commit 7d7f8ed — Add staff/DOC firm administration commands (PAR-11)
  • tesks changed status to Status → Pending Release
  • ParadauxIO linked a pull request — PR #7 merged — Reject '&' in firm + account names (PAR-53)
  • ParadauxIO linked a commit — Commit 9538158 — Reject '&' in firm + account names (PAR-53)
  • ParadauxIO linked a pull request — PR #7 open — Reject '&' in firm + account names (PAR-53)
  • ParadauxIO linked a commit — Commit 9538158 — Reject '&' in firm + account names (PAR-53)
  • tesks changed status to Status → In Progress
  • tesks changed status to Status → Backlog
  • tesks updated labels (Labels updated)
  • tesks description: Description updated
  • tesks commented
  • tesks assigned Assigned to rian