PAR-305
0
Model naming cleanup + collapse the dead economy-adapter abstraction + AdminBypass to a service
Pending ReleaseNormalUnassignedChestShopImprovement
Follow-ups after the layer reorg (PAR-304):
- Model names describe what they are — drop fluff suffixes: PlayerDTO and the *Context carriers (PreTransactionContext, TransactionContext, PreShopCreationContext, ShopCreatedContext, ShopDestroyedContext, BuildPermissionContext, ProtectionCheckContext) get names for what they model.
- Collapse the EconomyProvider abstraction — it's an abstract class whose only method (getProviderInfo) fed bStats, which was removed (PAR-303); with a single implementation it's dead weight. Remove EconomyProvider + ProviderInfo; TreasuryEconomyProvider stands alone.
- AdminBypass → @Singleton service — it holds per-player opt-out state (a Set), so it's a service, not a static util. Requires making the bypass-aware permission check (currently static Permissions.has) injectable.
Resources
- commit96effdd Name models for what they are, not their role (drop DTO/Context fluff) (PAR-305)ParadauxIO/hibernia-economy
- commit0310cd2 Make AdminBypass a @Singleton service; keep Permissions a pure static util (PAR-305)ParadauxIO/hibernia-economy
- commitee82b2f Collapse the dead EconomyProvider adapter abstraction (PAR-305)ParadauxIO/hibernia-economy
Comments
No comments yet.
Activity
- tesks changed status to Status → Pending Release
- ParadauxIO linked a commit — Commit 96effdd — Name models for what they are, not their role (drop DTO/Context fluff) (PAR-305)
- ParadauxIO linked a commit — Commit 0310cd2 — Make AdminBypass a @Singleton service; keep Permissions a pure static util (PAR-305)
- ParadauxIO linked a commit — Commit ee82b2f — Collapse the dead EconomyProvider adapter abstraction (PAR-305)
- tesks created the issue